From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] enhancement for unmaskable MSI and two cosmetic fixes. Date: Tue, 26 Jan 2010 15:01:37 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Zhang, Xiantao" , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Is patch #3 even safe? Looks like if a CPU somehow got all dynamic vectors stacked up, it would overflow into the stackpointer at the end of the array. -- Keir On 26/01/2010 14:35, "Zhang, Xiantao" wrote: > Yeah, at least we have to apply the first two to fix a bug related to > unmaskable MSI. > Xiantao > > -----Original Message----- > From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] > Sent: Tuesday, January 26, 2010 10:26 PM > To: Zhang, Xiantao; xen-devel@lists.xensource.com > Subject: Re: [PATCH] enhancement for unmaskable MSI and two cosmetic fixes. > > Are these essential for 4.0.0? I've just tagged -rc2, so they've missed > that. > > -- Keir > > On 26/01/2010 14:10, "Zhang, Xiantao" wrote: > >> 0001: Revert 20334, since it doesn't solve the race for all corner cases. >> 0002: Fixed unmaskable MSI's IRQ migration. >> 0003: Reduce eoi stack's size to save per-cpu area. >> 0004: polarity-switch method for EOI message is only used for >> non-directed-eoi >> case. >> Xiantao > >