Re: RE: [PATCH 1/2] Vcpu hotplug: Move ACPI processor from \_PR to \_SB

[Keir Fraser <keir.fraser@eu.citrix.com>]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

On 12/02/2010 10:07, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:

>> Win2k8 has a similar problem?
>> 
>>  -- Keir
> 
> Yes. Yunhong test Win2k8, and found in Win2k8 data center version, cpu hotplug
> successed for _SB definition, but failed for _PR definition. (success mean,
> after we hot-add vcpu, the device manager will shown new processor, but the
> task manager has no changes, same as
> http://www.boche.net/blog/index.php/2009/05/10/vsphere-memory-hot-add-cpu-hot-
> plug/ .Fail mean even the device manager has no changes).

Okay, how about the attached alternative patch then? Smaller than yours but
hoepfully equivalent. It doesn't include your change to the _STA method to
return 0 instead of 9 in the offline case however -- there was no
explanation for that in the changeset comment?

 -- Keir


[-- Attachment #2: 00-dsdt --]
[-- Type: application/octet-stream, Size: 1869 bytes --]

diff -r 3bb163b74673 tools/firmware/hvmloader/acpi/mk_dsdt.c
--- a/tools/firmware/hvmloader/acpi/mk_dsdt.c	Fri Feb 12 09:24:18 2010 +0000
+++ b/tools/firmware/hvmloader/acpi/mk_dsdt.c	Fri Feb 12 10:27:47 2010 +0000
@@ -83,7 +83,7 @@
     indent_level++;
 
     /**** Processor start ****/
-    push_block("Scope", "\\_PR");
+    push_block("Scope", "\\_SB");
 
     /* MADT checksum */
     stmt("OperationRegion", "MSUM, SystemMemory, \\_SB.MSUA, 1");
@@ -150,16 +150,16 @@
         /* Extract current CPU's status: 0=offline; 1=online. */
         stmt("And", "Local1, 1, Local2");
         /* Check if status is up-to-date in the relevant MADT LAPIC entry... */
-        push_block("If", "LNotEqual(Local2, \\_PR.PR%02X.FLG)", cpu);
+        push_block("If", "LNotEqual(Local2, \\_SB.PR%02X.FLG)", cpu);
         /* ...If not, update it and the MADT checksum, and notify OSPM. */
-        stmt("Store", "Local2, \\_PR.PR%02X.FLG", cpu);
+        stmt("Store", "Local2, \\_SB.PR%02X.FLG", cpu);
         push_block("If", "LEqual(Local2, 1)");
         stmt("Notify", "PR%02X, 1", cpu); /* Notify: Device Check */
-        stmt("Subtract", "\\_PR.MSU, 1, \\_PR.MSU"); /* Adjust MADT csum */
+        stmt("Subtract", "\\_SB.MSU, 1, \\_SB.MSU"); /* Adjust MADT csum */
         pop_block();
         push_block("Else", NULL);
         stmt("Notify", "PR%02X, 3", cpu); /* Notify: Eject Request */
-        stmt("Add", "\\_PR.MSU, 1, \\_PR.MSU"); /* Adjust MADT csum */
+        stmt("Add", "\\_SB.MSU, 1, \\_SB.MSU"); /* Adjust MADT csum */
         pop_block();
         pop_block();
     }
@@ -171,7 +171,7 @@
     /* Define GPE control method '_L02'. */
     push_block("Scope", "\\_GPE");
     push_block("Method", "_L02");
-    stmt("Return", "\\_PR.PRSC()");
+    stmt("Return", "\\_SB.PRSC()");
     pop_block();
     pop_block();
     /**** Processor end ****/

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel