From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Christoph Egger <Christoph.Egger@amd.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH][XEN] p2m cleanup: remove unused function
Date: Tue, 02 Mar 2010 18:03:34 +0000 [thread overview]
Message-ID: <C7B30376.BA48%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <201003021820.52535.Christoph.Egger@amd.com>
On 02/03/2010 17:20, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> Attached patch removes gfn_to_mfn_current(). It is redundant and effectively
> unused.
Hm, well, it's unused after your patch, but used a fair bit right now. It'll
need an Ack from Tim Deegan, who's on holiday until middle of next week.
> All remaining users now use proper replacement function.
> => No functional change.
>
> While here, silence stdvga
Is that a bug fix? Anyhow would belong in a separate properly explained
patch.
> and use page_mode_hap()
> consequently.
I see you change over to using page_mode_hap() in a few places. I wasn't
sure on the justification. If you could get rid of
arch.hvm_domain.hap_enabled entirely that might make it seem more
worthwhile. Again, it would need Ack from Tim.
-- Keir
next prev parent reply other threads:[~2010-03-02 18:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 17:20 [PATCH][XEN] p2m cleanup: remove unused function Christoph Egger
2010-03-02 18:03 ` Keir Fraser [this message]
2010-03-03 11:25 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C7B30376.BA48%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Christoph.Egger@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.