From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH 03/17] vmx: nest: wrapper for control update
Date: Thu, 20 May 2010 13:57:18 +0100
Message-ID: <C81AF03E.14ADE%keir.fraser@eu.citrix.com>
References: <20100520094638.GB21042@qhe2-db>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20100520094638.GB21042@qhe2-db>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Qing He <qing.he@intel.com>, Tim Deegan <Tim.Deegan@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 20/05/2010 10:46, "Qing He" <qing.he@intel.com> wrote:

>> Shouldn't this use the new vmx_update_exception_bitmap()?
> 
> I left it unchanged because it's in vmcs.c. To me, vmx.c is on top of
> vmcs.c and I feel against inter-dependeny.

The pslit between vmx.c and vmcs.c is a bit arbitrary in some cases. But
it's cleaner and more maintainable to have everyone use a single interface
to the exception bitmap if possible.

 -- Keir

> Anyway this feeling is not strong. And I'm fine with using
> vmx_update_exception_bitmap here since inter-dependency is already
> the case.