From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] hg ignore libxl lex/yacc detritus Date: Fri, 16 Jul 2010 17:50:53 +0100 Message-ID: References: <1be65436-b363-4862-a3f4-e55a997014fb@default> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1be65436-b363-4862-a3f4-e55a997014fb@default> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dan Magenheimer , "xen-devel@lists.xensource.com" Cc: Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Changeset 21000 checked those files into the tree, so adding them to .hgignore would be very bad form. I've missed checking in bits of patches due to that before. If they are getting modified (i.e., regenerated) as part of your build then that is a bug. Possibly the rules to generate them should be commented out in the checked-in Makefile in that case... Whatever, I leave it to Stefano and Ian to make a decision on that. But the right patch won't touch .hgignore. -- Keir On 16/07/2010 17:34, "Dan Magenheimer" wrote: > Please apply (this or some cleaner variation) to > xen-unstable and xen-4.0-testing so that hg diff > is clean after a build. > > diff -r 57859775f88f .hgignore > --- a/.hgignore Fri Jul 09 12:44:53 2010 +0100 > +++ b/.hgignore Fri Jul 16 10:24:02 2010 -0600 > @@ -317,3 +317,5 @@ > ^unmodified_drivers/linux-2.6/.*\.ko$ > ^unmodified_drivers/linux-2.6/.*\.mod\.c$ > ^LibVNCServer.* > +^tools/libxl/libxlu_cfg_l\.h$ > +^tools/libxl/libxlu_cfg_y\.h$ > +^tools/libxl/libxlu_cfg_l\.c$ > +^tools/libxl/libxlu_cfg_y\.c$