From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] hg ignore libxl lex/yacc detritus Date: Wed, 21 Jul 2010 17:59:50 +0100 Message-ID: References: <84053479-8cc4-497e-a70a-f4b3cf4b190b@default> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <84053479-8cc4-497e-a70a-f4b3cf4b190b@default> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dan Magenheimer , Ian Jackson Cc: "xen-devel@lists.xensource.com" , Stabellini Stefano List-Id: xen-devel@lists.xenproject.org On 21/07/2010 17:42, "Dan Magenheimer" wrote: >> They should be regenerated if the corresponding input files >> (libxlu_cfg.l and libxlu_cfg.y) have changed. I think make will avoid >> rebuilding them if they haven't. So the make lines shouldn't be >> commented out. > > Hmmm... that means they get regenerated when an "hg update" > is done that updates the input files, resulting in the > files being found by hg diff, which appears to be > what prompted my .hgignore patch. Yes, tbh I'm not sure we can really rely on the mtimes of the input files and the checked-in generated output files being correctly ordered in a fresh checkout of our repository. I had to comment out the rules to generate our virtual ACPI tables in tools/firmware/hvmloader/acpi when I used to have the output of the ACPI compiler checked in (I've got rid of that now). So, really, it may be we either need to remove the checked-in generated files, or comment out the rules that build those generated files. Because we can't rely on the file modification times being 'right' in a fresh checkout. -- Keir