From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 0/4] XSAVE/XRSTOR fixes and enhancements Date: Tue, 31 Aug 2010 08:41:30 +0100 Message-ID: References: <4C7CB0AE.6050908@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4C7CB0AE.6050908@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Weidong Han Cc: Tim Deegan , Jeremy Fitzhardinge , Xen-devel List-Id: xen-devel@lists.xenproject.org On 31/08/2010 08:35, "Weidong Han" wrote: >> Breaks backward compatibility by changing size of vcpu_guest_context (part >> of the PV guest ABI). Totally unacceptable -- is this a nasty attempt to get >> > yes, it cannot restore guest saved by old Xen. do you mean we should not > change size of vcpu_guest_context in future? Yes, and it's not just a save/restore issue. The PV guest itself handles vcpu_guest_context when booting secondary vcpus (via VCPUOP_initialise). The structure layout/size is set in stone. -- Keir