All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.xen@gmail.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	"Kay, Allen M" <allen.m.kay@intel.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Jean Guyader <Jean.Guyader@citrix.com>
Subject: Re: RE: [PATCH] remove _PS0 from the DSDTo
Date: Mon, 28 Feb 2011 15:52:38 +0000	[thread overview]
Message-ID: <C9917546.13ED9%keir.xen@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1102281115590.19277@kaball-desktop>

On 28/02/2011 15:33, "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>
wrote:

> On Sat, 26 Feb 2011, Kay, Allen M wrote:
>> Hi Stefano,
>> 
>> I just tried this patch booting Win7-64bit in following two configurations:
>> 
>>     1) Passthrough two NIC devices - onboard + PCIe E1000
>>     2) Passthrough SNB IGD + USB + audio + NIC
>> 
>> In both cases, Windows failed to boot complaining about BIOS is not ACPI
>> compliant.
>> 
>> If I don't passthrough any devices, Windows can boot successfully.
>> 
> 
> In that case we have a problem because I don't see any other way we
> could fix the issue in a way that is acceptable for xen 4.1.
> We could emulate PM capabilities in qemu even for devices that don't
> support it or make the presence of _PS0 conditional on the presence of
> PM capabilities on the devices. In both cases the fix will miss 4.1.

Stefano: Your patch should have deleted the _PS3 method along with _PS0. It
is an ACPI requirement that if you define an object to turn a device off
(i.e., _PS3 in this case) then you must also supply a symmetric object to
turn on the device (i.e., _PS0). So you must remove both, and there's no
reason not to since they both only contain debug stuff.

I suggest try again and see if _PS3 removal solves Allen's Windows boot
issue.

 -- Keir

> However there is a simple workaround for it: just disable acpi in the
> config file of the VM.

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

  reply	other threads:[~2011-02-28 15:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-23 14:18 [PATCH] remove _PS0 from the DSDT Stefano Stabellini
2011-02-26  0:02 ` Kay, Allen M
2011-02-28 15:33   ` [PATCH] remove _PS0 from the DSDTo Stefano Stabellini
2011-02-28 15:52     ` Keir Fraser [this message]
2011-02-28 16:21       ` Stefano Stabellini
2011-02-28 16:39     ` Paolo Bonzini
2011-02-28 16:41       ` Stefano Stabellini
2011-03-17 18:31         ` Jason Kwon
2011-03-17 18:40           ` Stefano Stabellini
2011-03-17 19:12             ` Jason Kwon
2011-03-17 19:15               ` Stefano Stabellini
2011-03-17 21:21                 ` Jason Kwon
2011-03-18 11:45                   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C9917546.13ED9%keir.xen@gmail.com \
    --to=keir.xen@gmail.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=Jean.Guyader@citrix.com \
    --cc=allen.m.kay@intel.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.