From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: irq_enter/irq_exit undeclared in efi/runtime.c Date: Thu, 14 Jul 2011 14:32:48 +0100 Message-ID: References: <20110714120454.GA29523@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110714120454.GA29523@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Olaf Hering Cc: xen-devel@lists.xensource.com, Jan Beulich List-Id: xen-devel@lists.xenproject.org On 14/07/2011 13:04, "Olaf Hering" wrote: > On Thu, Jul 14, Keir Fraser wrote: > >> On 14/07/2011 11:28, "Olaf Hering" wrote: >> >>> >>> Current xen-unstable fails to compile with gcc 4.6: >> >> Builds for me with 4.6. > > Does your build have -Wall? The xen.spec I use has this before the make > call: > > export 'CFLAGS=-fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 > -fstack-protector -funwind-tables -fasynchronous-unwind-tables' Yes, we always build -Wall. It could be the _FORTIFY_SOURCE=2? I think that's caused warnings/errors before. Anyway, in short I think you'll have to send us a sensible-looking patch that works for you, and we'll apply it. -- Keir > Olaf