From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH 1 of 3] Enable UEFI BIOS(OVMF) support in
	Xen-unstable HVM
Date: Sat, 23 Jul 2011 17:50:32 +0100
Message-ID: <CA50BA68.1E732%keir.xen@gmail.com>
References: <CAEQjb-TUxF7BUJx-ProK83fciByoLrNfso3URjEnkT2LeVutWQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <CAEQjb-TUxF7BUJx-ProK83fciByoLrNfso3URjEnkT2LeVutWQ@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Bei Guan <gbtju85@gmail.com>, Keir Fraser <keir@xen.org>
Cc: edk2-devel@lists.sourceforge.net, Xen Devel <xen-devel@lists.xensource.com>, Jordan Justen <jljusten@gmail.com>, Tim Deegan <Tim.Deegan@citrix.com>, Andrei Warkentin <andreiw@motorola.com>
List-Id: xen-devel@lists.xenproject.org

On 23/07/2011 16:18, "Bei Guan" <gbtju85@gmail.com> wrote:

> Do you mean that put the bios_relocate hook in the "else" statement? Just=
 like
> this:
>=20
> =A0 =A0 if (bios->load) {
> =A0 =A0 =A0 =A0 bios->load(bios);
> =A0 =A0 } else {
> =A0 =A0 =A0 =A0 printf("Loading %s ...\n", bios->name);
> =A0 =A0 =A0 =A0 memcpy((void *)bios->bios_address, bios->image,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0bios->image_size);
>=20
> =A0 =A0 =A0 =A0 if (bios->bios_relocate)
> =A0 =A0 =A0 =A0 =A0 =A0 bios->bios_relocate();=A0
> =A0=A0 }

No I mean remove the bios_relocate hook entirely, and modify the rombios
handler to use your new hook instead. It should be quite easy.

 -- Keir