From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: RE: [PATCH] [RFC] VT-d: always clean up dpci timers. Date: Mon, 25 Jul 2011 15:47:59 +0100 Message-ID: References: <20110725142120.GD8970@whitby.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110725142120.GD8970@whitby.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Tim Deegan Cc: "xen-devel@lists.xensource.com" , "Kay, Allen M" List-Id: xen-devel@lists.xenproject.org On 25/07/2011 15:21, "Tim Deegan" wrote: >> Could we make need_iommu(d) sticky? Being able to clear it doesn't seem an >> important case (such a domain is probably being torn down anyway) and >> clearly it can lead to fragility. The fact that presumably we'd end up doing >> unnecessary IOMMU PT work for the remaining lifetime of the domain doesn't >> seem a major downside to me. > > If you prefer it that way. TBH I think I prefer the other way though: > things that gate on need_iommu() should be cleaned up by > iommu->teardown(). Is your original patch still proposed as a valid alternative to this one? -- Keir