From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH] IRQ Cleanup: rename  nr_ioapic_registers to
	nr_ioapic_entries
Date: Mon, 26 Sep 2011 09:27:27 -0700
Message-ID: <CAA5F5FF.217CE%keir.xen@gmail.com>
References: <20110926154514.GB17331@phenom.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20110926154514.GB17331@phenom.oracle.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 26/09/2011 08:45, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com> wrote:

>> I guess it depends on whether you consider that we should stay in line
>> with Linux or not.  While the code did start in Linux, it has diverged
> 
> Stay. Intel does a lot of work of "lift from Linux" and drop in Xen
> code. There is similarity.

You might also say it gives a false sense of similarity. Andrew's now having
to go fix the per-cpu vector stuff for example. It got dropped in; it was
complex and opaque; it doesn't really work properly yet. I'd prefer the
people doing the porting to have to think about each line a bit more.

 -- Keir