From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: build failure caused by $(XEN_ROOT)/.config
Date: Thu, 06 Oct 2011 09:00:49 +0100
Message-ID: <CAB31EC1.22461%keir.xen@gmail.com>
References: <4E8D313F.8040809@ts.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4E8D313F.8040809@ts.fujitsu.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Juergen Gross <juergen.gross@ts.fujitsu.com>, "Kay, Allen M" <allen.m.kay@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 06/10/2011 05:40, "Juergen Gross" <juergen.gross@ts.fujitsu.com> wrote:

> =20
>  Uuh, the same bug was introduced again.
>  Could you try the following patch:

Whilst this is definitely a valid fix, Allen's build was crashing out from
tools/check. This is unlikely to fix it.

 -- Keir

>  diff -r 0b66e6450ffe tools/libfsimage/xfs/Makefile
>  --- a/tools/libfsimage/xfs/Makefile     Tue Oct 04 14:18:30 2011 +0200
>  +++ b/tools/libfsimage/xfs/Makefile     Thu Oct 06 06:32:00 2011 +0200
>  @@ -1,4 +1,4 @@ XEN_ROOT =3D ../../..
>  -XEN_ROOT =3D ../../..
>  +XEN_ROOT =3D $(CURDIR)/../../..
>  =20
>   LIB_SRCS-y =3D fsys_xfs.c
>  =20
> =20
>  Keir, it is easy to catch this problem: create a .config file in all
> directories
>  _above_ $XEN_ROOT containing something like:
> =20
>  $(error usage of relative XEN_ROOT somewhere in $(MAKEFILE_LIST))
> =20
> =20
>  Juergen
> =20
> =20
>> =20
>> =20
>>=20
>> =20
>> =20
>> =20
>> Allen
>> =20
>> =20
>> =20
>> =20
>> =20
>> =20
>> =20
>>=20
>> From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
>>  Sent: Tuesday, October 04, 2011 9:45 PM
>>  To: Kay, Allen M
>>  Cc: xen-devel@lists.xensource.com; keir@xen.org
>>  Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config
>> =20
>> =20
>> =20
>> =20
>> =20
>> On 10/04/2011 11:44 PM, Kay, Allen M wrote:
>> =20
>> Hi Keir,
>> =20
>> =20
>> =20
>> I=B9m getting the following build error caused by =B3-include
>> $(XEN_ROOT)/.config=B2 line in Config.mk.  Removing it from Config.mk make=
s the
>> error go away.  The OS I=B9m using is FC15.  =B3$(XEN_ROOT)/.config=B2 does no=
t
>> exist.
>> =20
>> =20
>> =20
>> Allen
>> =20
>> =20
>> =20
>> -------
>> =20
>> =20
>> =20
>> make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'
>> =20
>> make[4]: *** ../../.config: Is a directory.  Stop.
>> =20
>> make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'
>> =20
>> make[3]: *** [subdir-clean-check] Error 2
>> =20
>> make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
>> =20
>> make[2]: *** [subdirs-clean] Error 2
>> =20
>> make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
>> =20
>> make[1]: *** [clean] Error 2
>> =20
>> make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'
>> =20
>> make: *** [world] Error 2
>> =20
>> =20
>> =20
>>=20
>>  This is fixed with cs 23049 in xen-unstable:
>> =20
>>  http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.htm=
l
>> =20
>> =20
>>  Juergen
>> =20
>> =20
>> =20