From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: build failure caused by $(XEN_ROOT)/.config Date: Thu, 06 Oct 2011 19:33:28 +0100 Message-ID: References: <987664A83D2D224EAE907B061CE93D5301EE6A3084@orsmsx505.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0672554758==" Return-path: In-Reply-To: <987664A83D2D224EAE907B061CE93D5301EE6A3084@orsmsx505.amr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Kay, Allen M" , Juergen Gross Cc: "xen-devel@lists.xensource.com" , Ian Jackson List-Id: xen-devel@lists.xenproject.org > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --===============0672554758== Content-type: multipart/alternative; boundary="B_3400774411_51790690" > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3400774411_51790690 Content-type: text/plain; charset="ISO-8859-1" Content-transfer-encoding: quoted-printable Yes, as Ian Jackson has noted, this is because the fix for this in xen-unstable has not been backported. I think Ian Jackson may be proposing to do the backport. If not, you=B9ll just have to manually =8Ctouch .config=B9 at the root of your Xen repository, and get on with that. -- Keir On 06/10/2011 19:27, "Kay, Allen M" wrote: > Here is the exact build error I get in xen-4.1-testing: > =20 > make[4]: Entering directory `/tmp/xen-4.1-testing.hg/tools/check' > make[4]: *** ../../.config: Is a directory. Stop. > make[4]: Leaving directory `/tmp/xen-4.1-testing.hg/tools/check' > make[3]: *** [subdir-clean-check] Error 2 > make[3]: Leaving directory `/tmp/xen-4.1-testing.hg/tools' > make[2]: *** [subdirs-clean] Error 2 > make[2]: Leaving directory `/tmp/xen-4.1-testing.hg/tools' > make[1]: *** [clean] Error 2 > make[1]: Leaving directory `/tmp/xen-4.1-testing.hg' > make: *** [world] Error 2 > =20 > =20 >=20 > From: Kay, Allen M > Sent: Thursday, October 06, 2011 11:18 AM > To: 'Juergen Gross' > Cc: xen-devel@lists.xensource.com; keir@xen.org > Subject: RE: [Xen-devel] build failure caused by $(XEN_ROOT)/.config > =20 > Hi Juergen, > =20 > This patch fixes the build problem for xen-unstable but do not apply to > xen-4.1-testing. Xen-4.1-testing do not have xfs directory and still has= the > same build error. > =20 > Allen > =20 >=20 > From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com] > Sent: Wednesday, October 05, 2011 9:41 PM > To: Kay, Allen M > Cc: xen-devel@lists.xensource.com; keir@xen.org > Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config > =20 > Hi Allen, >=20 > On 10/05/2011 06:24 PM, Kay, Allen M wrote: >> > This is fixed with cs 23049 in xen-unstable: >> >=20 >> > http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.ht= ml > =20 > I=B9m using the latest staging tree (cs# 23903) and still seeing this probl= em. >=20 > Uuh, the same bug was introduced again. > Could you try the following patch: >=20 > diff -r 0b66e6450ffe tools/libfsimage/xfs/Makefile > --- a/tools/libfsimage/xfs/Makefile Tue Oct 04 14:18:30 2011 +0200 > +++ b/tools/libfsimage/xfs/Makefile Thu Oct 06 06:32:00 2011 +0200 > @@ -1,4 +1,4 @@ XEN_ROOT =3D ../../.. > -XEN_ROOT =3D ../../.. > +XEN_ROOT =3D $(CURDIR)/../../.. > =20 > LIB_SRCS-y =3D fsys_xfs.c > =20 >=20 > Keir, it is easy to catch this problem: create a .config file in all > directories > _above_ $XEN_ROOT containing something like: >=20 > $(error usage of relative XEN_ROOT somewhere in $(MAKEFILE_LIST)) >=20 >=20 > Juergen >=20 >=20 > =20 > Allen > =20 > =20 >=20 > From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com] > Sent: Tuesday, October 04, 2011 9:45 PM > To: Kay, Allen M > Cc: xen-devel@lists.xensource.com; keir@xen.org > Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config > =20 > On 10/04/2011 11:44 PM, Kay, Allen M wrote: > Hi Keir, > =20 > I=B9m getting the following build error caused by =B3-include $(XEN_ROOT)/.co= nfig=B2 > line in Config.mk. Removing it from Config.mk makes the error go away. = The > OS I=B9m using is FC15. =B3$(XEN_ROOT)/.config=B2 does not exist. > =20 > Allen > =20 > ------- > =20 > make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check' > make[4]: *** ../../.config: Is a directory. Stop. > make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check' > make[3]: *** [subdir-clean-check] Error 2 > make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools' > make[2]: *** [subdirs-clean] Error 2 > make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools' > make[1]: *** [clean] Error 2 > make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg' > make: *** [world] Error 2 > =20 >=20 > This is fixed with cs 23049 in xen-unstable: >=20 > http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html >=20 >=20 > Juergen --B_3400774411_51790690 Content-type: text/html; charset="ISO-8859-1" Content-transfer-encoding: quoted-printable Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config Yes, as Ian Jackson has noted, this is because the fix for this in xen-uns= table has not been backported. I think Ian Jackson may be proposing to do th= e backport. If not, you’ll just have to manually ‘touch .config&= #8217; at the root of your Xen repository, and get on with that.

 -- Keir


On 06/10/2011 19:27, "Kay, Allen M" <allen.m.kay@intel.com> wrote:

<= SPAN STYLE=3D'font-size:11pt'>Here is the exact build er= ror I get in xen-4.1-testing:
 
make[4]: Entering directory `/tmp/xen-4.1-testing.hg/tools/check'
make[4]: *** ../../.config: Is a directory.  Stop.
make[4]: Leaving directory `/tmp/xen-4.1-testing.hg/tools/check'
make[3]: *** [subdir-clean-check] Error 2
make[3]: Leaving directory `/tmp/xen-4.1-testing.hg/tools'
make[2]: *** [subdirs-clean] Error 2
make[2]: Leaving directory `/tmp/xen-4.1-testing.hg/tools'
make[1]: *** [clean] Error 2
make[1]: Leaving directory `/tmp/xen-4.1-testing.hg'
make: *** [world] Error 2
 
 

From: Kay, Allen M
Sent: Thursday, October 06, 2011 11:18 AM
To: 'Juergen Gross'
Cc: xen-devel@lists.xensourc= e.com; keir@xen.org
Subject: RE: [Xen-devel] build failure caused by $(XEN_ROOT)/.config=

Hi Juergen,
 
This patch fixes the build problem for xen-unstable but do not apply to xen= -4.1-testing.  Xen-4.1-testing do not have xfs directory and still has = the same build error.
 
Allen
 

From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
Sent: Wednesday, October 05, 2011 9:41 PM
To: Kay, Allen M
Cc: xen-devel@lists.xensourc= e.com; keir@xen.org
Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config=

Hi Allen,

On 10/05/2011 06:24 PM, Kay, Allen M wrote:
> This is fixed with cs 23049 in xen-unstable:
>
> http://lists.xensource.com/archives/html/xen-devel/2011-03/msg0= 1251.html
 
I’m using the latest staging tree (cs# 23903) and still seeing this p= roblem.

Uuh, the same bug was introduced again.
Could you try the following patch:

diff -r 0b66e6450ffe tools/libfsimage/xfs/Makefile
--- a/tools/libfsimage/xfs/Makefile     Tue Oct 04 14:1= 8:30 2011 +0200
+++ b/tools/libfsimage/xfs/Makefile     Thu Oct 06 06:3= 2:00 2011 +0200
@@ -1,4 +1,4 @@ XEN_ROOT =3D ../../..
-XEN_ROOT =3D ../../..
+XEN_ROOT =3D $(CURDIR)/../../..
 
 LIB_SRCS-y =3D fsys_xfs.c
 

Keir, it is easy to catch this problem: create a .config file in all direct= ories
_above_ $XEN_ROOT containing something like:

$(error usage of relative XEN_ROOT somewhere in $(MAKEFILE_LIST))


Juergen
Allen
 

From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
Sent: Tuesday, October 04, 2011 9:45 PM
To: Kay, Allen M
Cc: xen-devel@lists.xensourc= e.com; keir@xen.org
Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config=

On 10/04/2011 11:44 PM, Kay, Allen M wrote:
Hi Keir,
 
I’m getting the following build error caused by “-include $(XEN= _ROOT)/.config” line in Config.mk.  Removing it from Config.mk ma= kes the error go away.  The OS I’m using is FC15.  “$(= XEN_ROOT)/.config” does not exist.
 
Allen
 
-------
 
make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'
make[4]: *** ../../.config: Is a directory.  Stop.
make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'
make[3]: *** [subdir-clean-check] Error 2
make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
make[2]: *** [subdirs-clean] Error 2
make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
make[1]: *** [clean] Error 2
make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'
make: *** [world] Error 2
This is fixed with cs 23049 in xen-unstable:

http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.= html


Juergen
--B_3400774411_51790690-- --===============0672554758== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0672554758==--