From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH] Avoid relative XEN_ROOT specification
Date: Fri, 07 Oct 2011 09:00:32 +0100
Message-ID: <CAB47030.22675%keir.xen@gmail.com>
References: <1317973890.21903.280.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1317973890.21903.280.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Campbell <Ian.Campbell@citrix.com>, Juergen Gross <juergen.gross@ts.fujitsu.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 07/10/2011 08:51, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:

> On Fri, 2011-10-07 at 05:42 +0100, Juergen Gross wrote:
>> XEN_ROOT must be set to an absolute path to avoid out of the tree references
> 
> How about:
> 
> # HG changeset patch
> # User Ian Campbell <ian.campbell@citrix.com>
> # Date 1317973741 -3600
> # Node ID d0327c39dff8abdc224e3c19f31e11f0fbeb5c16
> # Parent  f17f0df2a2ede01a8c35dc4768a532a4438b1c02
> tools: error out on non-absolute $(XEN_ROOT)
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Why not put this in root Config.mk? The restriction applies outside tools/
as well.

 -- Keir

> diff -r f17f0df2a2ed -r d0327c39dff8 tools/Rules.mk
> --- a/tools/Rules.mk Wed Oct 05 10:43:41 2011 +0100
> +++ b/tools/Rules.mk Fri Oct 07 08:49:01 2011 +0100
> @@ -3,6 +3,10 @@
>  # `all' is the default target
>  all:
>  
> +ifeq ($(filter /%,$(XEN_ROOT)),)
> +$(error XEN_ROOT must be absolute)
> +endif
> +
>  include $(XEN_ROOT)/Config.mk
>  
>  export _INSTALL := $(INSTALL)
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel