From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>,
Juergen Gross <juergen.gross@ts.fujitsu.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Avoid panic when adjusting sedf parameters
Date: Thu, 17 Nov 2011 13:48:36 +0000 [thread overview]
Message-ID: <CAEAC134.25132%keir.xen@gmail.com> (raw)
In-Reply-To: <4EC51A8D0200007800061933@nat28.tlf.novell.com>
On 17/11/2011 13:30, "Jan Beulich" <JBeulich@suse.com> wrote:
>> +#define for_each_domain_in_cpupool(_d,_c) \
>> + for ( (_d) = rcu_dereference(domain_list); \
>> + (_d) != NULL; \
>> + (_d) = rcu_dereference((_d)->next_in_list )) \
>
> Wouldn't this, up to here, simply be for_each_domain()?
>
>> + if ((_d)->cpupool == (_c))
>
> This is dangerous - consider code like
I also wonder (and this is true for the existing open-coded versions too)
whether we have sufficient locking around use of d->cpupool? Do these loops
hold enough locks to ensure that d->cpupool doesn't change under their feet?
-- Keir
next prev parent reply other threads:[~2011-11-17 13:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 13:03 [PATCH] Avoid panic when adjusting sedf parameters Juergen Gross
2011-11-17 13:30 ` Jan Beulich
2011-11-17 13:48 ` Keir Fraser [this message]
2011-11-17 14:02 ` Juergen Gross
2011-11-17 13:52 ` Keir Fraser
2011-11-17 14:04 ` Juergen Gross
2011-11-17 14:32 ` Jan Beulich
2011-11-17 14:41 ` Juergen Gross
2011-11-17 14:29 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2011-11-17 14:37 Juergen Gross
2011-11-17 12:33 Juergen Gross
2011-11-17 12:43 ` George Dunlap
2011-11-17 13:07 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEAC134.25132%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=juergen.gross@ts.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.