From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: __vmptrst() broken...
Date: Tue, 22 Nov 2011 07:46:09 +0000
Message-ID: <CAF103C1.25562%keir.xen@gmail.com>
References: <20111121184743.281f8364@mantra.us.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20111121184743.281f8364@mantra.us.oracle.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Mukesh Rathor <mukesh.rathor@oracle.com>, "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 22/11/2011 02:47, "Mukesh Rathor" <mukesh.rathor@oracle.com> wrote:

> Hi Keir,
> 
> __vmptrst() seems broken. It is:
> 
> static inline void __vmptrst(u64 addr)
> {
>     asm volatile ( VMPTRST_OPCODE
>                    MODRM_EAX_07
>                    :
>                    : "a" (&addr)
>                    : "memory");
> }
> 
> 
> should be:
> 
> static inline void __vmptrst(u64 *addr)
> {           
>     asm volatile ( VMPTRST_OPCODE
>                    MODRM_EAX_07
>                    :
>                    : "a" (addr)
>                    : "memory");
> }   
> 
> 
> 
> Do you think you can just fix it in one of your changes without
> official patch?

It's obviously not used. It's probably not even useful (we know what VMCS we
last loaded). I'll just remove it.

 -- Keir

> thanks much,
> Mukesh