From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Fix save/restore for HVM domains with viridian=1 Date: Fri, 25 Nov 2011 15:16:30 +0000 Message-ID: References: <4ECFBB26020000780006356F@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4ECFBB26020000780006356F@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , paul.durrant@citrix.com Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 25/11/2011 14:58, "Jan Beulich" wrote: >> xc_domain_save/restore currently pay no attention to HVM_PARAM_VIRIDIAN >> which >> results in an HVM domain running a recent version on Windows (post-Vista) >> locking up on a domain restore due to EOIs (done via a viridian MSR write) >> being silently dropped. >> This patch adds an extra save entry for the viridian parameter and also >> adds code in the viridian kernel module to catch attempted use of viridian >> functionality when the HVM parameter has not been set. > > Assuming this means the changes to {rd,wr}msr_viridian_regs(), isn't > this going to needlessly spam the log? I.e. printing this just once (per > VM) would seem to suffice. Or alternatively I would think that > HVM_DBG_LOG() would be a better choice here. It's unlikely to print more than once before the VM wedges. We could go further and inject #GP, which we ought to be doing anyway. -- Keir