From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: Need help with fixing the Xen waitqueue feature Date: Fri, 25 Nov 2011 19:35:01 +0000 Message-ID: References: <20111125182645.GA27992@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111125182645.GA27992@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Olaf Hering Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 25/11/2011 18:26, "Olaf Hering" wrote: > > One more thing: > > Is the BUG_ON in destroy_waitqueue_vcpu really required? If the vcpu > happens to be in a queue by the time xl destroy is called the hypervisor > will crash. We could fix this by having waitqueues that contain a vcpu hold a reference to that vcpu's domain. > Perhaps there should be some sort of domain destructor for each > waitqueue? Not sure what you mean. -- Keir > Olaf