Re: [PATCH v4 04/15] nvmet: Implement CCR logpage

[Randy Jennings <randyj@purestorage.com>]

On Fri, Mar 27, 2026 at 5:45 PM Mohamed Khalfella
<mkhalfella@purestorage.com> wrote:
>
> Defined by TP8028 Rapid Path Failure Recovery, CCR (Cross-Controller
> Reset) log page contains an entry for each CCR request submitted to
> source controller. Implement CCR logpage for nvme linux target.

> +/* NVMe Cross-Controller Reset Status */
> +enum {
> +       NVME_CCR_STATUS_IN_PROGRESS,
> +       NVME_CCR_STATUS_SUCCESS,
> +       NVME_CCR_STATUS_FAILED,
> +};
> +
Looking at the rest of the code, all the enums are defined except
/* NVMe Namespace Write Protect State */
which does define the value of the first entry (0).

I think it would be prefereable to add explicit values here (0, 1, 2) even
though the implicit values should be correct.

Sincerely,
Randy Jennings