From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: KEXEC: fix kexec_get_range_compat to fail vocally Date: Mon, 05 Dec 2011 19:46:33 +0000 Message-ID: References: <4EDCAC68.8060303@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4EDCAC68.8060303@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andrew Cooper , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 05/12/2011 11:35, "Andrew Cooper" wrote: > I am not sure that this is the only instance, but it is really not > acceptable to hand truncated pointers or sizes for physical memory to dom0. I applied as c/s 24358 but I changed the mask-checking arithmetic a bit. Not only is it now shorter, I'm also more certain that it is correct: It looks to me like ~((unsigned int)-1) performs the ~ before promotion to unsigned long, hence this term ends up as 0 rather than 0xffffffff00000000. -- Keir