Re: [PATCH] x86: convert BUG_ON()s to WARN_ON()s in read_descriptor()

[Keir Fraser <keir@xen.org>]

On 15/12/2011 13:06, "Jan Beulich" <JBeulich@suse.com> wrote:

>>>> On 15.12.11 at 13:36, Keir Fraser <keir@xen.org> wrote:
>> On 15/12/2011 10:25, "Jan Beulich" <JBeulich@suse.com> wrote:
>> 
>>> In the light of AMD erratum #700, and given that these checks happen
>>> for debugging purposes only and also only in debug builds of the
>>> hypervisor, make the failures non-fatal.
>>> 
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> 
>> Is this erratum published?
> 
> Yes, it is in their most recent public revision guide.

Do you have a link? I can't find a published erratum > #686.

 -- Keir

> Jan
> 
>>> --- a/xen/arch/x86/traps.c
>>> +++ b/xen/arch/x86/traps.c
>>> @@ -1544,11 +1544,11 @@ static int read_descriptor(unsigned int
>>>              asm volatile (
>>>                  "larl %2,%0 ; setz %1"
>>>                  : "=r" (a), "=qm" (valid) : "rm" (sel));
>>> -            BUG_ON(valid && ((a & 0x00f0ff00) != *ar));
>>> +            WARN_ON(valid && ((a & 0x00f0ff00) != *ar));
>>>              asm volatile (
>>>                  "lsll %2,%0 ; setz %1"
>>>                  : "=r" (l), "=qm" (valid) : "rm" (sel));
>>> -            BUG_ON(valid && (l != *limit));
>>> +            WARN_ON(valid && (l != *limit));
>>>          }
>>>  #endif
>>>      }
>>> 
>>> 
>>> 
>>> _______________________________________________
>>> Xen-devel mailing list
>>> Xen-devel@lists.xensource.com
>>> http://lists.xensource.com/xen-devel
> 
> 
>