From: Keir Fraser <keir@xen.org>
To: George Dunlap <george.dunlap@citrix.com>,
Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
Marcus Granado <Marcus.Granado@eu.citrix.com>,
xen-devel <xen-devel@lists.xensource.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 3/3] xenoprof: Make the escape code consistent across 32 and 64-bit xen
Date: Mon, 23 Jan 2012 17:31:28 +0000 [thread overview]
Message-ID: <CB4349F0.37FDB%keir@xen.org> (raw)
In-Reply-To: <1327337503.26455.314.camel@elijah>
On 23/01/2012 16:51, "George Dunlap" <george.dunlap@citrix.com> wrote:
> On Mon, 2012-01-23 at 16:30 +0000, Jan Beulich wrote:
>>> The attached patch fixes the build (with the original patch un-reverted
>>> of course), by making the internal calls explicitly take 64-bit values
>>> for eip, rather than "unsigned long". Will that suffice?
>>
>> Looks correct and sufficient, but with the original patch already
>> reverted folding the changes here into the original and re-submitting
>> would probably the best route to go.
>
> I really prefer to keep patches with no functional change separate from
> those with a pretty major functional change; even if the major
> functional change is only one line. :-)
The one-line major functional change didn't work. Obviously the other
changes to make it build must be part of the same logical patch.
-- Keir
next prev parent reply other threads:[~2012-01-23 17:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 18:45 [PATCH 3/3] xenoprof: Make the escape code consistent across 32 and 64-bit xen Marcus Granado
2012-01-23 9:57 ` Jan Beulich
2012-01-23 10:16 ` Ian Campbell
2012-01-23 10:47 ` Jan Beulich
2012-01-23 14:04 ` Jan Beulich
2012-01-23 16:01 ` George Dunlap
2012-01-23 16:30 ` Jan Beulich
2012-01-23 16:51 ` George Dunlap
2012-01-23 17:01 ` Jan Beulich
2012-01-23 17:31 ` Keir Fraser [this message]
2012-01-23 17:40 ` George Dunlap
2012-01-24 8:50 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB4349F0.37FDB%keir@xen.org \
--to=keir@xen.org \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=Marcus.Granado@eu.citrix.com \
--cc=george.dunlap@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.