From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH, RFC] Re: x86: gnttab_clear_flag() abusing clear_bit()
Date: Thu, 09 Feb 2012 04:33:38 -0800 [thread overview]
Message-ID: <CB58FD22.2AC03%keir.xen@gmail.com> (raw)
In-Reply-To: <4F3399820200007800071D17@nat28.tlf.novell.com>
On 09/02/2012 01:01, "Jan Beulich" <JBeulich@suse.com> wrote:
>> Looks fine to me, in principle. I would add a comment to the x86
>> gnttab_clear_flag() explaining why we have to open code something that looks
>> a lot like clear_bit().
>
> That one I already did, will submit soon (desiring clarification on the
> below).
>
> As to the "+m" constraint - I'm being told that "+m" (var) is equivalent
> to "=m" (var) : "m" (var), no matter what the documentation says
> regarding '+' (but they're also not seeing a need to adjust the docs
> accordingly).
>
> The question is whether we should go with the (documentation-wise
> correct) form, or the shorter one (which they're unlikely to change
> the meaning of, given in how many places "+m" is used in e.g. Linux).
You could switch us to "+m" and see how we get on.
-- Keir
prev parent reply other threads:[~2012-02-09 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 17:06 x86: gnttab_clear_flag() abusing clear_bit() Jan Beulich
2012-02-07 10:34 ` [PATCH, RFC] " Jan Beulich
2012-02-07 5:10 ` Keir Fraser
2012-02-09 9:01 ` Jan Beulich
2012-02-09 12:33 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB58FD22.2AC03%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.