Re: [PATCH 1/5] build: Export configure variables to hypervisor build

[Keir Fraser <keir.xen@gmail.com>]

On 29/02/2012 15:06, "Daniel De Graaf" <dgdegra@tycho.nsa.gov> wrote:

> On 02/29/2012 06:44 AM, Ian Jackson wrote:
>> Ian Campbell writes ("Re: [Xen-devel] [PATCH 1/5] build: Export configure
>> variables to hypervisor build"):
>>> Perhaps we should just move the configure stuff up to the top level and
>>> agree that it can control both tools and hypervisor configuration
>>> options? I'm not sure why we would want to use different mechanisms for
>>> the tools and h/v anyway.
>> 
>> I assume that the concern was that some people might object to the
>> involvement of autoconf in building the hypervisor.  But no-one seems
>> to be objecting very much.
>> 
>> If they do then the right thing is for configure to automatically
>> honour settings like FLASK_ENABLE, not to have two separate options
>> which cause the build to fail unless you set or clear both.
>> 
>> Ian.
>> 
> 
> Actually, FLASK_ENABLE and XSM_ENABLE are not used in the tools build at all -
> they are purely hypervisor build options. If a ./configure dependency isn't
> wanted for the hypervisor build, reverting the removal of XSM_ENABLE from
> Config.mk and eliminating the --enable-xsm option would also work.

I'll revert the patch I just applied. Do you want to make another patch for
this alternative solution?

 -- Keir