From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 1/5] build: Export configure variables to hypervisor build Date: Wed, 29 Feb 2012 15:09:15 +0000 Message-ID: References: <4F4E3EE5.4020703@tycho.nsa.gov> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F4E3EE5.4020703@tycho.nsa.gov> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Daniel De Graaf , Ian Jackson Cc: Roger Pau Monne , "Keir (Xen.org)" , Ian Campbell , Jan Beulich , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 29/02/2012 15:06, "Daniel De Graaf" wrote: > On 02/29/2012 06:44 AM, Ian Jackson wrote: >> Ian Campbell writes ("Re: [Xen-devel] [PATCH 1/5] build: Export configure >> variables to hypervisor build"): >>> Perhaps we should just move the configure stuff up to the top level and >>> agree that it can control both tools and hypervisor configuration >>> options? I'm not sure why we would want to use different mechanisms for >>> the tools and h/v anyway. >> >> I assume that the concern was that some people might object to the >> involvement of autoconf in building the hypervisor. But no-one seems >> to be objecting very much. >> >> If they do then the right thing is for configure to automatically >> honour settings like FLASK_ENABLE, not to have two separate options >> which cause the build to fail unless you set or clear both. >> >> Ian. >> > > Actually, FLASK_ENABLE and XSM_ENABLE are not used in the tools build at all - > they are purely hypervisor build options. If a ./configure dependency isn't > wanted for the hypervisor build, reverting the removal of XSM_ENABLE from > Config.mk and eliminating the --enable-xsm option would also work. I'll revert the patch I just applied. Do you want to make another patch for this alternative solution? -- Keir