From: Keir Fraser <keir.xen@gmail.com>
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: NMI: Enable watchdog by default
Date: Wed, 07 Mar 2012 17:41:55 +0000 [thread overview]
Message-ID: <CB7D4E63.2DDF9%keir.xen@gmail.com> (raw)
In-Reply-To: <CAFLBxZZVt1=q3QYfW=E9jGRe7q7RH5eY+8-WnR742CPfqwfysg@mail.gmail.com>
On 07/03/2012 17:35, "George Dunlap" <George.Dunlap@eu.citrix.com> wrote:
> On Wed, Mar 7, 2012 at 5:11 PM, Keir Fraser <keir@xen.org> wrote:
>> On 07/03/2012 16:55, "Andrew Cooper" <andrew.cooper3@citrix.com> wrote:
>>
>>> This patch is based on one which has been in XenServer for a very long.
>>>
>>> To keep the trend of documentation going, it also corrects the new
>>> command line document.
>>
>> This does not only enable the watchdog by default, but also changes the
>> timeout from 5 seconds to 5 *minutes*!
>>
>> Even if that is a good idea in some cases, we'd at least have to make the
>> timeout configurable. Developers will not appreciate having to wait for 5
>> minutes for their lockups to produce useful trace output.
>
> Yes, the 5 minute timeout is what we ship for production boxes, so
> that we can catch actual deadlocks while being *really really* sure we
> don't take down a customer's system unless it's *really* dead. I
> think leaving the timeout as it is and making it configurable is
> probably the best option.
A patch to do that would be acceptable. With that we may as well keep NMI
watchdog disabled by default, and default timeout of 5 seconds. That then
means that XenServer carries a command-line option for its watchdog
settings, rather than a patch.
-- Keir
> -George
>
>>
>> -- Keir
>>
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-03-07 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 16:55 NMI: Enable watchdog by default Andrew Cooper
2012-03-07 17:08 ` Jan Beulich
2012-03-07 17:11 ` Keir Fraser
2012-03-07 17:35 ` George Dunlap
2012-03-07 17:41 ` Keir Fraser [this message]
2012-03-07 18:14 ` NMI: watchdog timeout command line parameter Andrew Cooper
2012-03-08 10:06 ` Jan Beulich
2012-03-08 10:22 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB7D4E63.2DDF9%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.