From: Keir Fraser <keir@xen.org>
To: wei.huang2@amd.com, Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Boris Ostrovsky <boris.ostrovsky@amd.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] svm: Do not intercept RDTCS(P) when TSC scaling is supported by hardware
Date: Wed, 25 Apr 2012 18:14:49 +0100 [thread overview]
Message-ID: <CBBDEF99.3EECC%keir@xen.org> (raw)
In-Reply-To: <4F982098.8070003@amd.com>
On 25/04/2012 17:04, "Wei Huang" <wei.huang2@amd.com> wrote:
>> I certainly don't feel comfortable ACKing it. I'd like
>> to see some testing that demonstrates the patch either improves
>> functionality or performance without breaking other things.
>> But if nobody else shares my concern, I don't feel that
>> I have the right to block it either.
>
> We can provide some rdtsc performance numbers. Regarding functionality,
> it is relatively hard to prove unless Dan has some more specific ideas
> of testing it. I think the hardware rdtsc scaling is inline with
> software-based emulated approach.
I've put it in to xen-unstable. I'm not sure about putting into 4.1 for the
forthcoming release from that branch.
-- Keir
next prev parent reply other threads:[~2012-04-25 17:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 2:21 [PATCH] svm: Do not intercept RDTCS(P) when TSC scaling is supported by hardware Boris Ostrovsky
2012-04-20 3:57 ` Huang2, Wei
2012-04-20 8:05 ` Keir Fraser
2012-04-20 8:14 ` Keir Fraser
2012-04-20 15:06 ` Huang2, Wei
2012-04-20 16:56 ` Keir Fraser
2012-04-20 15:02 ` Dan Magenheimer
2012-04-20 16:20 ` Wei Huang
2012-04-20 17:25 ` Dan Magenheimer
2012-04-20 8:15 ` Jan Beulich
2012-04-20 8:45 ` Keir Fraser
2012-04-20 15:27 ` Boris Ostrovsky
2012-04-25 9:27 ` Jan Beulich
2012-04-25 15:01 ` Dan Magenheimer
2012-04-25 15:51 ` Jan Beulich
2012-04-25 16:05 ` Dan Magenheimer
2012-04-25 16:04 ` Wei Huang
2012-04-25 17:14 ` Keir Fraser [this message]
2012-04-25 20:07 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CBBDEF99.3EECC%keir@xen.org \
--to=keir@xen.org \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@amd.com \
--cc=dan.magenheimer@oracle.com \
--cc=wei.huang2@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.