From: Keir Fraser <keir@xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: ns16550.c's poll_port variable
Date: Fri, 04 May 2012 13:03:24 +0100 [thread overview]
Message-ID: <CBC9841C.3FAFF%keir@xen.org> (raw)
In-Reply-To: <4FA3D4320200007800081987@nat28.tlf.novell.com>
On 04/05/2012 12:05, "Jan Beulich" <JBeulich@suse.com> wrote:
>> I'm unclear on exactly what you want to optimise away? Certainly the 8 bytes
>> per CPU of the poll_port variable isn't worth much optimising effort.
>
> Certainly not (and as you say they are actually needed, even if
> only rarely). But the pointlessly running timer(s) might be, as might
> the buffer(s) set up via serial_async_transmit().
We could delay {init,setup}_postirq until a corresponding serial handle has
been created via serial_parse_handle()? The logic might be a bit ugly and
spread across both serial.c and ns16550.c but not actually particularly
complicated?
-- Keir
next prev parent reply other threads:[~2012-05-04 12:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 8:18 ns16550.c's poll_port variable Jan Beulich
2012-05-04 8:25 ` Keir Fraser
2012-05-04 9:12 ` Jan Beulich
2012-05-04 9:40 ` Keir Fraser
2012-05-04 11:05 ` Jan Beulich
2012-05-04 12:03 ` Keir Fraser [this message]
2012-05-04 12:46 ` Jan Beulich
2012-05-04 13:27 ` Keir Fraser
2012-05-04 13:55 ` Jan Beulich
2012-05-04 13:59 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CBC9841C.3FAFF%keir@xen.org \
--to=keir@xen.org \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.