All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Liam Beguin" <liambeguin@gmail.com>
To: "Peter Rosin" <peda@axentia.se>, <jic23@kernel.org>,
	<lars@metafoo.de>, <pmeerw@pmeerw.net>
Cc: <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <robh+dt@kernel.org>
Subject: Re: [PATCH v1 8/9] dt-bindings: iio: afe: add binding for temperature-sense-current
Date: Mon, 31 May 2021 09:41:24 -0400	[thread overview]
Message-ID: <CBRH2RWDHKFD.20XDGCMHA282F@shaak> (raw)
In-Reply-To: <fe79916e-8ea8-5059-fd68-0e0ec621a2e1@axentia.se>

Hi Peter,

On Mon May 31, 2021 at 4:58 AM EDT, Peter Rosin wrote:
>
>
> On 2021-05-31 09:28, Peter Rosin wrote:
> >> +  use-kelvin-scale:
> >> +    type: boolean
> >> +    description: |
> >> +      Boolean indicating if alpha uses Kelvin degrees instead of Celsius.
> > 
> > It's "kelvin", not "Kelvin degrees", and it's "degrees Celsius".

I'll rephrase the description base on your comment.

I also thought of using alpha-micro-amps-per-degree-celsius and
alpha-micro-amps-kelvin instead. I don't know if that would be better.

Thanks,
Liam

> > 
> > But what exactly is this property for? We always want degrees Celsius, don't we,
> > and any offset can be handled...with an offset. No?
>
> Ahh, I hit send too soon. I now see that you calculate the offset in the
> driver
> instead of requiring the devicetree author to do it "by hand".
>
> Cheers,
> Peter


  reply	other threads:[~2021-05-31 14:15 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-30  0:59 [PATCH v1 0/9] iio: afe: add temperature rescaling support Liam Beguin
2021-05-30  0:59 ` [PATCH v1 1/9] iio: inkern: always apply scale requested by consumer Liam Beguin
2021-05-31 13:39   ` Peter Rosin
2021-05-30  0:59 ` [PATCH v1 2/9] iio: inkern: error out on unsupported offset type Liam Beguin
2021-05-31  9:45   ` Peter Rosin
2021-05-31 13:31     ` Liam Beguin
2021-05-30  0:59 ` [PATCH v1 3/9] iio: afe: rescale: use core to get processed value Liam Beguin
2021-05-31  7:09   ` Peter Rosin
2021-05-31 13:23     ` Liam Beguin
2021-06-01 16:22   ` Jonathan Cameron
2021-05-30  0:59 ` [PATCH v1 4/9] iio: afe: rescale: add offset support Liam Beguin
2021-05-31  8:52   ` Peter Rosin
2021-05-31 13:36     ` Liam Beguin
2021-05-31 14:08       ` Peter Rosin
2021-05-31 14:51         ` Liam Beguin
2021-05-31 16:25           ` Peter Rosin
2021-05-31 17:42             ` Liam Beguin
2021-06-01 16:31               ` Jonathan Cameron
2021-05-30  0:59 ` [PATCH v1 5/9] iio: afe: rescale: add support for temperature sensors Liam Beguin
2021-06-01 16:34   ` Jonathan Cameron
2021-05-30  0:59 ` [PATCH v1 6/9] dt-bindings: iio: afe: update MAINTAINERS file Liam Beguin
2021-05-31  7:57   ` Peter Rosin
2021-05-30  0:59 ` [PATCH v1 7/9] dt-bindings: iio: afe: add binding for temperature-sense-rtd Liam Beguin
2021-06-01 16:43   ` Jonathan Cameron
2021-06-04 21:17   ` Rob Herring
2021-06-05 14:58     ` Jonathan Cameron
2021-05-30  0:59 ` [PATCH v1 8/9] dt-bindings: iio: afe: add binding for temperature-sense-current Liam Beguin
2021-05-31  7:28   ` Peter Rosin
2021-05-31  8:58     ` Peter Rosin
2021-05-31 13:41       ` Liam Beguin [this message]
2021-06-01 16:47   ` Jonathan Cameron
2021-06-04 21:21   ` Rob Herring
2021-05-30  0:59 ` [PATCH v1 9/9] dt-bindings: iio: afe: add binding for temperature-sense-amplifier Liam Beguin
2021-05-31  7:32   ` Peter Rosin
2021-05-31 14:03     ` Liam Beguin
2021-06-01 16:02       ` Jonathan Cameron
2021-06-01 16:07         ` Jonathan Cameron
2021-06-01 15:59   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CBRH2RWDHKFD.20XDGCMHA282F@shaak \
    --to=liambeguin@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.