From: Keir Fraser <keir@xen.org>
To: M A Young <m.a.young@durham.ac.uk>, Bastian Blank <waldi@debian.org>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Fix asmlinkage functions
Date: Wed, 20 Jun 2012 09:43:28 +0100 [thread overview]
Message-ID: <CC074BC0.43308%keir@xen.org> (raw)
In-Reply-To: <alpine.GSO.2.00.1206200922330.4323@algedi.dur.ac.uk>
On 20/06/2012 09:28, "M A Young" <m.a.young@durham.ac.uk> wrote:
> On Tue, 19 Jun 2012, Bastian Blank wrote:
>
>> According to gcc-4.7, "void bla(void)" is incompatible with "asmlinkage
>> void bla(void)". As asmlinkage expands to __attribute__((regparm(0))),
>> it is correct.
>>
>> The patch adds the missing asmlinkage to function declarations affected.
>> It is needed for 4.1 and 4.2.
>>
>> Signed-off-by: Bastian Blank <waldi@debian.org>
>
> This is only relevant for 4.1 . In 4.2 asmlinkage got flattened to a no-op
> in changeset 24511
> http://xenbits.xen.org/hg/staging/xen-unstable.hg/rev/a141f6d64916 . It
> would be a good idea to get this problem fixed for 4.1.3 but backporting
> the change from 4.2 might be a better idea.
Done, and for forthcoming 4.0.4-rc3 too.
> Michael Young
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2012-06-20 8:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 19:12 [PATCH] Fix asmlinkage functions Bastian Blank
2012-06-20 7:59 ` Jan Beulich
2012-06-20 8:12 ` Bastian Blank
2012-06-20 8:42 ` Keir Fraser
2012-06-20 8:28 ` M A Young
2012-06-20 8:43 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC074BC0.43308%keir@xen.org \
--to=keir@xen.org \
--cc=m.a.young@durham.ac.uk \
--cc=waldi@debian.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.