From: Keir Fraser <keir.xen@gmail.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [RFC] Spurious PIC interrupts
Date: Wed, 29 Aug 2012 10:50:00 +0100 [thread overview]
Message-ID: <CC63A458.3D30F%keir.xen@gmail.com> (raw)
In-Reply-To: <503DDC13.30206@citrix.com>
On 29/08/2012 10:08, "Andrew Cooper" <andrew.cooper3@citrix.com> wrote:
>> No, you should make the change to _mask_and_ack_8259A_irq() itself, and
>> callers which do not care about the return code can simply discard it.
>
> Ok - I initially avoided that because _mask_and_ack_8259A_irq() is used
> to fill a function pointer structure, and preferred less change to the core.
>
> I will re-design somewhat with these points in mind.
Worst case rename to __mask_and_ack_8259A_irq() and implement new
_mask_and_ack_8259A_irq() which simply calls it and discards the return
code. Still much better than duplicating the function.
-- Keir
prev parent reply other threads:[~2012-08-29 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 19:59 [RFC] Spurious PIC interrupts Andrew Cooper
2012-08-28 21:32 ` Keir Fraser
2012-08-29 9:08 ` Andrew Cooper
2012-08-29 9:50 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC63A458.3D30F%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.