All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] ACPI: move tables.c fully into .init.*
Date: Wed, 19 Sep 2012 12:40:32 +0100	[thread overview]
Message-ID: <CC7F6DC0.3F265%keir.xen@gmail.com> (raw)
In-Reply-To: <5059A56C020000780009C430@nat28.tlf.novell.com>

On 19/09/2012 09:58, "Jan Beulich" <JBeulich@suse.com> wrote:

> Of course, if you're only against the dynamic allocation, moving
> the array elsewhere would be another option (but would require
> making the symbol global, whereas here the symbol goes away
> altogether from the symbol tables).
> 
> Yet another option would be to do the dynamic allocation where
> it was actually intended to be done, passing NULL here. The
> resizing there isn't being made use of anyway (and wouldn't
> work afaict), so we could as well do away with it and replace it
> by the simple allocation needed here (or simply fix it,
> considering that we might need it at some point).

I'm not wild about any of the options really. Perhaps passing NULL would be
best. Still, overall, I'm not *that* bothered. You can have my Ack for the
original patch:
Acked-by: Keir Fraser <keir@xen.org>

 -- Keir

  reply	other threads:[~2012-09-19 11:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18 15:26 [PATCH] ACPI: move tables.c fully into .init.* Jan Beulich
2012-09-18 15:42 ` Keir Fraser
2012-09-19  7:29   ` Jan Beulich
2012-09-19  7:56     ` Keir Fraser
2012-09-19  8:58       ` Jan Beulich
2012-09-19 11:40         ` Keir Fraser [this message]
2012-09-19 12:57           ` Jan Beulich
2012-09-19 14:45             ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CC7F6DC0.3F265%keir.xen@gmail.com \
    --to=keir.xen@gmail.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.