From: Keir Fraser <keir@xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] ACPI/APEI: fix ERST MOVE_DATA instruction implementation
Date: Wed, 17 Oct 2012 14:01:54 +0100 [thread overview]
Message-ID: <CCA46AD2.4FDB6%keir@xen.org> (raw)
In-Reply-To: <507EBD7002000078000A1FC9@nat28.tlf.novell.com>
On 17/10/2012 13:15, "Jan Beulich" <JBeulich@suse.com> wrote:
>>>> On 17.10.12 at 14:07, Keir Fraser <keir@xen.org> wrote:
>> On 17/10/2012 12:53, "Jan Beulich" <JBeulich@suse.com> wrote:
>>
>>> Before anyone asks - yes, I have added to my todo list to put in
>>> place a proper ioremap() for x86. But since I'm under some time
>>> pressure right now, this was the faster route to something that
>>> can be committed to see whether the regression goes away.
>>
>> That's good as we'll need it for >4kB per-VCPU stacks (even if we only need
>> 4kB VCPU stacks, we'll want a guard page too).
>
> But why would you want to do that via ioremap()?
Well the required missing mechanism is the same, right? The ability to
allocate some unused virtual address space. We already have
map_pages_to_xen(), so it's just the allocation part that is missing for
either ioremap() or vcpu stacks.
-- Keir
> Jan
>
prev parent reply other threads:[~2012-10-17 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 11:36 [PATCH] ACPI/APEI: fix ERST MOVE_DATA instruction implementation Jan Beulich
2012-10-17 11:47 ` Keir Fraser
2012-10-17 11:53 ` Jan Beulich
2012-10-17 12:07 ` Keir Fraser
2012-10-17 12:15 ` Jan Beulich
2012-10-17 13:01 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CCA46AD2.4FDB6%keir@xen.org \
--to=keir@xen.org \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.