All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xen.org>
To: Jan Beulich <JBeulich@suse.com>,
	Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	TimDeegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen-devel@lists.xen.org, Zhigang Wang <zhigang.x.wang@oracle.com>
Subject: Re: Please ack XENMEM_claim_pages hypercall?
Date: Tue, 27 Nov 2012 10:22:02 +0000	[thread overview]
Message-ID: <CCDA44CA.5383C%keir@xen.org> (raw)
In-Reply-To: <50B48C8A02000078000AB851@nat28.tlf.novell.com>

On 27/11/2012 08:48, "Jan Beulich" <JBeulich@suse.com> wrote:

> Sorry, there must have been some misunderstanding here: First
> of all, without a maintainer's ack (Keir's in this case) I can't commit
> anything to code that I'm not explicitly listed for as maintainer.
> 
> Second, while I said the code itself looks acceptable, I also pointed
> out that in the shape it is right now it is dead code, as there's no
> user for it. So all we would get would be the risk of new bugs (and
> the one I just pointed out worries me in so far as how much testing
> this code really has seen).
> 
> Third, deferral (or denial) of the patch going in is certainly not a
> blocking factor for tools side development at Oracle. In the worst
> case, you'd have to maintain the patch in your own tree(s); I do
> realize that you want to avoid that (as I would, but there are
> examples of patches that we carry in our trees that didn't get
> accepted into the community one - luckily they're of smaller size).

It's actually not that large a patch, and perhaps we could take a
domain_adjust_tot_pages() hook which would reduce the size of any private
patch, while not inflicting a maintenance or bug burden on mainline.

 -- Keir

  reply	other threads:[~2012-11-27 10:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-26 19:07 Please ack XENMEM_claim_pages hypercall? Dan Magenheimer
2012-11-27  8:48 ` Jan Beulich
2012-11-27 10:22   ` Keir Fraser [this message]
2012-11-27 14:08     ` Dan Magenheimer
2012-11-27 14:47       ` Keir Fraser
2012-11-27 10:31   ` Ian Campbell
2012-11-27 14:15     ` Tim Deegan
2012-11-27 14:38     ` Dan Magenheimer
2012-11-27 14:46       ` George Dunlap
2012-11-29 16:00       ` Ian Jackson
2012-12-03 15:45         ` Dan Magenheimer
2012-11-27 14:06   ` Dan Magenheimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CCDA44CA.5383C%keir@xen.org \
    --to=keir@xen.org \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    --cc=zhigang.x.wang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.