From: Keir Fraser <keir@xen.org>
To: Lars Rasmusson <lra@sics.se>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
Daniel De Graaf <dgdegra@tycho.nsa.gov>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] xsm_remove_from_physmap is (so far) only defined for X86 architecture, not for ARM
Date: Fri, 11 Jan 2013 16:36:33 +0000 [thread overview]
Message-ID: <CD15F011.5840B%keir@xen.org> (raw)
In-Reply-To: <24906FE8-94BF-4694-9E2A-3737A5686405@sics.se>
On 11/01/2013 16:24, "Lars Rasmusson" <lra@sics.se> wrote:
>> On 11/01/2013 13:32, "lra@sics.se" <lra@sics.se> wrote:
>>
>>> From: Lars Rasmusson <Lars.Rasmusson@sics.se>
>>>
>>> Signed-off-by: Lars Rasmusson <Lars.Rasmusson@sics.se>
>>
>> If this is a build fix after my checkins this morning then:
>> Acked-by: Keir Fraser <keir@xen.org>
>
> Yes, the XEN_TARGET_ARCH=arm32 make breaks when compiling memory.c
>
> In xen/include/xsm/dummy.h where many of the functions are used, some are
> declared only for X86, so I picked the same #ifdef CONFIG_X86
> as the header file uses.
>
> As Ian said, it's not pretty, but since ARM doesn't have xsm (yet?) I think
> adding a dummy xsm_remove_from_physmap for arm also is ugly.
>
> Is there some other way to write memory.c so that it doesn't need
> xsm_remove...? (I mean, it does't need xsm_add....)
The XSM infrastructure is not architecture dependent. It's probably a
mistake that xsm_remove_from_physmap() is ifdef CONFIG_X86.
-- Keir
next prev parent reply other threads:[~2013-01-11 16:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 13:32 [PATCH] xsm_remove_from_physmap is (so far) only defined for X86 architecture, not for ARM lra
2013-01-11 13:40 ` Ian Campbell
2013-01-11 13:47 ` Keir Fraser
2013-01-11 16:24 ` Lars Rasmusson
2013-01-11 16:36 ` Keir Fraser [this message]
2013-01-11 16:46 ` Ian Campbell
2013-01-11 17:37 ` Daniel De Graaf
2013-01-15 11:18 ` Ian Campbell
2013-01-15 11:52 ` Stefano Stabellini
2013-01-15 13:42 ` Ian Campbell
2013-01-15 14:35 ` Daniel De Graaf
2013-01-17 17:05 ` Ian Campbell
2013-01-17 17:13 ` Daniel De Graaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CD15F011.5840B%keir@xen.org \
--to=keir@xen.org \
--cc=Ian.Campbell@eu.citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=lra@sics.se \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.