Re: [PATCH] xen: print "debug=y|n" during hypervisor startup

[Keir Fraser <keir.xen@gmail.com>]

On 30/01/2013 04:29, "Dario Faggioli" <dario.faggioli@citrix.com> wrote:

> So that we can easily figure out whether or not we are running a
> debug build of Xen (e.g., via `xl dmesg').
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
>
> diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -577,6 +577,11 @@ void __init console_init_preirq(void)
>  {
>      char *p;
>      int sh;
> +    char debug = 'n';
> +
> +#ifndef NDEBUG
> +    debug = 'y';
> +#endif
>  
>      serial_init_preirq();
>  
> @@ -608,9 +613,9 @@ void __init console_init_preirq(void)
>      spin_lock(&console_lock);
>      __putstr(xen_banner());
>      spin_unlock(&console_lock);
> -    printk("Xen version %d.%d%s (%s@%s) (%s) %s\n",
> +    printk("Xen version %d.%d%s (%s@%s debug=%c) (%s) %s\n",
>             xen_major_version(), xen_minor_version(), xen_extra_version(),
> -           xen_compile_by(), xen_compile_domain(),
> +           xen_compile_by(), xen_compile_domain(), debug,
>             xen_compiler(), xen_compile_date());

Rather odd to put it in with the xen_compile_by() info. How about before
xen_compile_date(), and not inside any brackets?

 -- Keir

>      printk("Latest ChangeSet: %s\n", xen_changeset());
>