From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 0/4] Add posted interrupt supporting Date: Wed, 10 Apr 2013 17:18:08 +0100 Message-ID: References: <5165948402000078000CC240@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5165948402000078000CC240@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Yang Z Zhang Cc: Xiantao Zhang , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 10/04/2013 15:34, "Jan Beulich" wrote: >>>> On 10.04.13 at 15:58, "Zhang, Yang Z" wrote: >> Are there any additional comments with this patch set? Also, what's your >> point of using static vector? >> If no, I will rebase the patch according to current comments. > > As said before, I'd prefer use of a dynamically allocated vector > unless you can prove that this won't perform well. Keir may > override my vote here though... Oh, yes, the vector should be allocated and initialised with alloc_direct_apic_vector(). That's probably true for a number of the existing statically-defined vectors too, but at least we should not create any more of them! -- Keir > Jan >