All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.xen@gmail.com>
To: Marek Marczykowski <marmarek@invisiblethingslab.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH] Try to use git commit id if hg changeset is unavailable
Date: Thu, 11 Apr 2013 07:40:21 +0100	[thread overview]
Message-ID: <CD8C1965.4F38C%keir.xen@gmail.com> (raw)
In-Reply-To: <20130410233918.66DF61D3@duch.mimuw.edu.pl>

On 11/04/2013 00:32, "Marek Marczykowski" <marmarek@invisiblethingslab.com>
wrote:

> As Xen uses git as primary repository, get git commit id for
> xen_changeset info.
> 
> Maybe hg code should be removed completely?
> 
> Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>

I think we could just remove the hg code. Any other opinions?

 -- Keir

> ---
>  xen/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/Makefile b/xen/Makefile
> index 0fb3db7..9e4e6f3 100644
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -126,7 +126,7 @@ include/xen/compile.h: include/xen/compile.h.in .banner
>    -e 's/@@version@@/$(XEN_VERSION)/g' \
>    -e 's/@@subversion@@/$(XEN_SUBVERSION)/g' \
>    -e 's/@@extraversion@@/$(XEN_EXTRAVERSION)/g' \
> -     -e 's!@@changeset@@!$(shell ((hg parents --template "{date|date}
> {rev}:{node|short}" >/dev/null && hg parents --template "{date|date}
> {rev}:{node|short}") || echo "unavailable") 2>/dev/null)!g' \
> +     -e 's!@@changeset@@!$(shell ((hg parents --template "{date|date}
> {rev}:{node|short}" >/dev/null && hg parents --template "{date|date}
> {rev}:{node|short}") || git show -s --pretty="%ad %h" || echo "unavailable")
> 2>/dev/null | tr -d '\n')!g' \
>    < include/xen/compile.h.in > $@.new
> @grep \" .banner >> $@.new
> @grep -v \" .banner

  reply	other threads:[~2013-04-11  6:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-10 23:32 [PATCH] Try to use git commit id if hg changeset is unavailable Marek Marczykowski
2013-04-11  6:40 ` Keir Fraser [this message]
2013-04-11  7:28   ` Jan Beulich
2013-04-11  7:33 ` Sander Eikelenboom
2013-04-11  7:41   ` Ian Campbell
2013-04-11  8:25     ` Sander Eikelenboom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CD8C1965.4F38C%keir.xen@gmail.com \
    --to=keir.xen@gmail.com \
    --cc=marmarek@invisiblethingslab.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.