From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH v7 1/2] xen: export do_block,
 add a parameter to enable local events delivery
Date: Fri, 19 Apr 2013 18:12:46 +0100
Message-ID: <CD97399E.50799%keir.xen@gmail.com>
References: <alpine.DEB.2.02.1304191715060.7254@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1304191715060.7254@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: Julien Grall <julien.grall@citrix.com>, "Tim (Xen.org)" <tim@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 19/04/2013 17:23, "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>
wrote:

> On Fri, 19 Apr 2013, Jan Beulich wrote:
>>>>> On 19.04.13 at 16:06, Stefano Stabellini
>>>>> <stefano.stabellini@eu.citrix.com> wrote:
>>> -static long do_block(void)
>>> +int do_block(int event_delivery_enable)
>> 
>> In the previous version you didn't need this new parameter, so
>> what changed since then?
> 
> I changed the ARM implementation of local_event_delivery_enable: now it
> clears PSR_IRQ_MASK (the interrupt flag). That is the correct behavior
> for the implementation of the SCHEDOP_block hypercall but it is not the
> right behavior for the WFI trap handler. In order to reuse this code, I
> had to add the event_delivery_enable parameter.

Given that basically you need special versions of both local_events_*()
calls in do_block() (in one case you nop it out, and in the other it is a
special case which ignores the irq mask), I think perhaps you are better
with your own version of do_block() rather than code sharing. It's only a
small function and it skanks up every caller in common code, and you're
practically abusing do_block() by trying to play nicely with it.

I would also suggest that _local_events_need_delivery() takes no parameter,
always ignores the mask, and instead push the mask check into
local_events_need_delivery(). Perhaps rename the former to
local_events_need_delivery_ignore_mask() or something.

 -- Keir

>> Also, please use bool_t for boolean parameters.
> 
> OK
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel