From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xensource.com
Cc: julien.grall@citrix.com, tim@xen.org, Ian.Campbell@citrix.com
Subject: Re: [PATCH v8 1/2] xen: introduce vcpu_block and vcpu_block_enable_events
Date: Tue, 23 Apr 2013 08:45:31 +0100 [thread overview]
Message-ID: <CD9BFAAB.22634%keir.xen@gmail.com> (raw)
In-Reply-To: <5176532102000078000CFC78@nat28.tlf.novell.com>
On 23/04/2013 08:23, "Jan Beulich" <JBeulich@suse.com> wrote:
>>>> On 22.04.13 at 22:00, Keir Fraser <keir.xen@gmail.com> wrote:
>> On 22/04/2013 18:42, "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>
>> wrote:
>>
>>> Rename do_block to vcpu_block.
>>>
>>> Move the call to local_event_delivery_enable out of vcpu_block, to a new
>>> function called vcpu_block_enable_events.
>>>
>>> Use vcpu_block_enable_events instead of do_block throughout in
>>> schedule.c
>>
>> While you're there, could you make both vcpu_block variants return void?
>
> And I don't see why vcpu_block_enable_events() needs to
> become non-static...
I must admit that I don't mind, no reason not to make it part of the API of
the scheduler, even if noone else uses it yet. OTOH I don't have a very
strong opinion either way.
-- Keir
> Jan
>
next prev parent reply other threads:[~2013-04-23 7:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 17:42 [PATCH v8 1/2] xen: introduce vcpu_block and vcpu_block_enable_events Stefano Stabellini
2013-04-22 20:00 ` Keir Fraser
2013-04-23 7:23 ` Jan Beulich
2013-04-23 7:45 ` Keir Fraser [this message]
2013-04-23 8:34 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CD9BFAAB.22634%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.