From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 1/3] xen/tools: Remove the XENMEM_get_oustanding_pages and provide the data via xc_phys_info Date: Fri, 10 May 2013 14:58:05 +0100 Message-ID: References: <518CCE0F02000078000D503D@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <518CCE0F02000078000D503D@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Ian Campbell , Konrad Rzeszutek Wilk Cc: George Dunlap , Tim Deegan , dgdegra@tycho.nsa.gov, Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 10/05/2013 09:38, "Jan Beulich" wrote: >>>> On 09.05.13 at 09:44, Ian Campbell wrote: >> On Wed, 2013-05-08 at 19:35 +0100, Konrad Rzeszutek Wilk wrote: >>> During the review of the patches it was noticed that there exists >>> a race wherein the 'free_memory' value consists of information from >>> two hypercalls. That is the XEN_SYSCTL_physinfo and >> XENMEM_get_outstanding_pages. >>> >>> The free memory the host has available for guest is the difference between >>> the 'free_pages' (from XEN_SYSCTL_physinfo) and 'outstanding_pages'. As they >>> are two hypercalls many things can happen in between the execution of them. >>> >>> This patch resolves this by eliminating the XENMEM_get_outstanding_pages >>> hypercall and providing the free_pages and outstanding_pages information >>> via the xc_phys_info structure. >>> >>> It also removes the XSM hooks and adds locking as needed. >>> >>> CC: dgdera@tycho.nsa.gov >>> Signed-off-by: Konrad Rzeszutek Wilk >> >> For the tools side: >> Acked-by: Ian Campbell >> >> Needs a hypervisor ack though, since contrary to the subject line this >> isn't just a tools change. Adding Keir, Tim & Jan (not sure which of >> them is the right one here). > > Looks okay to me (albeit quite late in the game for a bump of > XEN_SYSCTL_INTERFACE_VERSION), but from a formal > perspective Keir needs to ack this for it to go in. Acked-by: Keir Fraser > Jan >