From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>, Matt Wilson <msw@amazon.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] x86/apic: remove the legacy bigsmp APIC driver
Date: Tue, 27 Aug 2013 19:10:56 +0100 [thread overview]
Message-ID: <CE42AA40.5B985%keir.xen@gmail.com> (raw)
In-Reply-To: <521C7CC102000078000EEA76@nat28.tlf.novell.com>
On 27/08/2013 09:17, "Jan Beulich" <JBeulich@suse.com> wrote:
>>>> On 27.08.13 at 07:44, Matt Wilson <msw@amazon.com> wrote:
>> The bigsmp APIC driver was used on legacy (32-bit only) x86 platforms
>> with 8 or more CPUs. In Linux the X86_BIGSMP Kconfig option depends on
>> X86_32. Since we no longer support 32-bit hypervisors on the x86
>> platform we can remove this code.
>
> The fact that this is 32-bit only in Linux doesn't mean anything.
> Linux has other 64-bit only models, which we don't have (in
> favor of, originally, having a single shared implementation).
>
> On a system without x2APIC but more than 8 CPUs - how would
> you see us bringing up the CPUs beyond 8? This is particularly
> shown by your adjustment to MP_processor_info_x(), which is
> code removal without replacement.
>
> Despite Keir's ack, unless I'm overlooking something I'm explicitly
> nack-ing this.
Thanks. You are right of course. Oops!
> Jan
>
next prev parent reply other threads:[~2013-08-27 18:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 5:44 [PATCH] x86/apic: remove the legacy bigsmp APIC driver Matt Wilson
2013-08-27 6:08 ` Keir Fraser
2013-08-27 8:17 ` Jan Beulich
2013-08-27 18:10 ` Keir Fraser [this message]
2013-08-27 21:34 ` Matt Wilson
2013-08-28 7:44 ` Jan Beulich
2013-08-28 12:49 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE42AA40.5B985%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=msw@amazon.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.