From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] x86: AVX instruction emulation fixes Date: Wed, 28 Aug 2013 13:49:57 +0100 Message-ID: References: <521DD1CD02000078000EF000@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VEfCK-0006NN-KV for xen-devel@lists.xenproject.org; Wed, 28 Aug 2013 12:50:08 +0000 Received: by mail-wg0-f50.google.com with SMTP id m15so5359308wgh.29 for ; Wed, 28 Aug 2013 05:50:06 -0700 (PDT) In-Reply-To: <521DD1CD02000078000EF000@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org On 28/08/2013 09:32, "Jan Beulich" wrote: > - we used the C4/C5 (first prefix) byte instead of the apparent ModR/M > one as the second prefix byte > - early decoding normalized vex.reg, thus corrupting it for the main > consumer (copy_REX_VEX()), resulting in #UD on the two-operand > instructions we emulate > > Also add respective test cases to the testing utility plus > - fix get_fpu() (the fall-through order was inverted) > - add cpu_has_avx2, even if it's currently unused (as in the new test > cases I decided to refrain from using AVX2 instructions in order to > be able to actually run all the tests on the hardware I have) > - slightly tweak cpu_has_avx to more consistently express the outputs > we don't care about (sinking them all into the same variable) > > Signed-off-by: Jan Beulich Acked-by: Keir Fraser