From: "Shankar, Hari" <Hari.Shankar-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
To: "dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org"
<dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: "Singh,
Varinder"
<Varinder.Singh-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>,
"Sundaram,
Rajesh" <Rajesh.Sundaram-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>,
"Kimmel,
Jeff" <jeff.kimmel-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>,
"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"Spiller,
John" <John.Spiller-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
Subject: Re: bug in intel_iommu_unmap()
Date: Mon, 2 Sep 2013 01:54:32 +0000 [thread overview]
Message-ID: <CE493D74.414FF%hshankar@netapp.com> (raw)
In-Reply-To: <CE48F11D.4142A%hshankar-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 2090 bytes --]
Please ignore this email. Per suggestion from Alex, I will send another email to fix some style points related to the patch. Thanks Alex for pointing it out.
Hari.
From: <Shankar>, Hari <Hari.Shankar-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org<mailto:Hari.Shankar@netapp.com>>
Date: Sunday, September 1, 2013 1:26 PM
To: "dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org<mailto:dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>" <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org<mailto:dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org<mailto:iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+c@public.gmane.orgrg>" <iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org<mailto:iommu-cunTk1MwBs9QetFLy7KEmxxBWXNxL4zz@public.gmane.orgorg>>, "Kimmel, Jeff" <jeff.kimmel-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org<mailto:jeff.kimmel-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>>, "Spiller, John" <John.Spiller-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org<mailto:John.Spiller-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>>, "Singh, Varinder" <Varinder.Singh-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org<mailto:Varinder.Singh@netapp.com>>, "Sundaram, Rajesh" <Rajesh.Sundaram-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org<mailto:Rajesh.Sundaram-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>>, Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org<mailto:alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>>
Subject: bug in intel_iommu_unmap()
Hi David,
NetApp is using Linux VFIO code for user space drivers. We recently ran into a memory corruption bug which was root caused to lack of IOMMU TLB flush in intel_iommu_unmap() routine.
While reviewing the code we also figured that the unmap routine always returns size only for one page rather than the total unmapped size. Since VFIO unmaps one page at a time, the problem isn't exposed
Alex Williamson suggested that you're the maintainer of the code so sending to you for review.
Diff for the changes is attached and is generated on Linux kernel version 3.6.11
Hari.
[-- Attachment #1.2: Type: text/html, Size: 3551 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2013-09-02 1:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 20:26 bug in intel_iommu_unmap() Shankar, Hari
[not found] ` <CE48F11D.4142A%hshankar-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
2013-09-02 1:54 ` Shankar, Hari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE493D74.414FF%hshankar@netapp.com \
--to=hari.shankar-hgovqubeegtqt0dzr+alfa@public.gmane.org \
--cc=John.Spiller-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
--cc=Rajesh.Sundaram-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
--cc=Varinder.Singh-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jeff.kimmel-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.