From: Keir Fraser <keir.xen@gmail.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH 0/3] irqsave/restore improvements
Date: Mon, 21 Oct 2013 15:08:20 +0100 [thread overview]
Message-ID: <CE8AF3E4.61113%keir.xen@gmail.com> (raw)
In-Reply-To: <1382362893-12603-1-git-send-email-andrew.cooper3@citrix.com>
On 21/10/2013 14:41, "Andrew Cooper" <andrew.cooper3@citrix.com> wrote:
> This series contains two independent but related fixes to do with
> irqsave/restore semantics.
>
> The first patch prevents local_irq_restore() from corrupting system flags.
>
> The second was constructed using the compile errors from the third patch,
> separated for clarity and reordered to prevent bisection problems.
>
> The third patch uses a BUILD_BUG_ON() to ensure that the flags parameter to
> spin_lock_irqsave is wide enough to not trucate the result from
> local_irq_save().
>
> I have not compile tested on arm, so request that one of the maintainers
> explicitly acks the final patch. Any compile failures will almost certainly
> be fixed with an int->unsigned long conversion on the affected variable(s).
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Keir Fraser <keir@xen.org>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: Stefano Stabellini <stefano.stabellini@citrix.com>
> CC: Tim Deegan <tim@xen.org>
> CC: George Dunlap <george.dunlap@eu.citrix.com>
Acked-by: Keir Fraser <keir@xen.org>
> --
> 1.7.10.4
>
prev parent reply other threads:[~2013-10-21 14:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 13:41 [PATCH 0/3] irqsave/restore improvements Andrew Cooper
2013-10-21 13:41 ` [PATCH 1/3] x86/irq: local_irq_restore() should not blindly popf Andrew Cooper
2013-10-21 13:58 ` David Vrabel
2013-10-21 14:09 ` Keir Fraser
2013-10-21 14:32 ` Jan Beulich
2013-10-21 15:24 ` Jan Beulich
2013-10-21 14:42 ` Jan Beulich
2013-10-21 16:33 ` [Patch 1/3 v2] " Andrew Cooper
2013-10-21 18:18 ` Keir Fraser
2013-10-21 18:30 ` Andrew Cooper
2013-10-21 18:37 ` Keir Fraser
2013-10-22 8:35 ` Jan Beulich
2013-10-22 8:56 ` Andrew Cooper
2013-10-22 9:28 ` Jan Beulich
2013-10-22 10:14 ` [PATCH 1/3 v3] " Andrew Cooper
2013-10-22 13:27 ` Keir Fraser
2013-10-29 14:53 ` [Patch 1/3 v2] " Jan Beulich
2013-10-21 13:41 ` [PATCH 2/3] xen: Widen flags parameter for spinlock_irqsave() and friends Andrew Cooper
2013-10-21 13:41 ` [PATCH 3/3] common/spinlock: Ensure the flags parameter is wide enough Andrew Cooper
2013-10-21 15:15 ` Ian Campbell
2013-10-21 14:08 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE8AF3E4.61113%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.