From: Keir Fraser <keir.xen@gmail.com>
To: George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Tim Deegan <tim@xen.org>, Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [Patch v3 0/4] Xen stack trace printing improvements
Date: Tue, 19 Nov 2013 08:07:25 -0800 [thread overview]
Message-ID: <CEB0CCBD.66617%keir.xen@gmail.com> (raw)
In-Reply-To: <528B4520.1060905@eu.citrix.com>
On 19/11/2013 03:01, "George Dunlap" <george.dunlap@eu.citrix.com> wrote:
> On 11/19/2013 10:50 AM, Andrew Cooper wrote:
>> On 19/11/2013 10:10, George Dunlap wrote:
>> Benefits:
>> * Use frame pointers in the stack overflow case
>> * Correct boundaries for frame pointer traces
>> * Wild function pointer semantics in the common case now
>>
>> Risks:
>> * Issues with printing stack traces (although if you notice, I haven't
>> actually changed either of the printing algorithms)
>>
>> This series seemed accepted-in-principle at v1 ages ago, pending me
>> confirming the boundaries. (which have admittedly be tweaked in this
>> latest series).
>
> That makes more sense, thanks. If Jan and/or Keir see it that way, then
> the series is fine with me f/ a release perspective.
Yes, this series should go in.
-- Keir
> -George
next prev parent reply other threads:[~2013-11-19 16:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 19:34 [Patch v3 0/4] Xen stack trace printing improvements Andrew Cooper
2013-11-18 19:34 ` [Patch v3 1/4] x86/stack: Refactor show_trace() Andrew Cooper
2013-11-20 9:43 ` Jan Beulich
2013-11-18 19:34 ` [Patch v3 2/4] x86/stack: Adjust boundary conditions for printed stacks Andrew Cooper
2013-11-20 9:49 ` Jan Beulich
2013-11-18 19:34 ` [Patch v3 3/4] x86/stack: Change show_stack_overflow() to use frame pointers if available Andrew Cooper
2013-11-20 9:51 ` Jan Beulich
2013-11-18 19:34 ` [Patch v3 4/4] DO NOT APPLY: Test code for interesting stack overflows Andrew Cooper
2013-11-19 10:10 ` [Patch v3 0/4] Xen stack trace printing improvements George Dunlap
2013-11-19 10:50 ` Andrew Cooper
2013-11-19 11:01 ` George Dunlap
2013-11-19 16:07 ` Keir Fraser [this message]
2013-11-19 16:10 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CEB0CCBD.66617%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.