From: Keir Fraser <keir.xen@gmail.com>
To: Julien Grall <julien.grall@citrix.com>,
Julien Grall <julien.grall@linaro.org>
Cc: ian.campbell@citrix.com, patches@linaro.org,
stefano.stabellini@eu.citrix.com, tim@xen.org,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH V3] xen: Check if the range is valid in init_domheap_pages
Date: Wed, 20 Nov 2013 13:12:00 -0800 [thread overview]
Message-ID: <CEB265A0.66A01%keir.xen@gmail.com> (raw)
In-Reply-To: <528CDEBD.8060508@citrix.com>
On 20/11/2013 08:09, "Julien Grall" <julien.grall@citrix.com> wrote:
> On 11/13/2013 01:37 PM, Julien Grall wrote:
>> On ARM, when an initrd is given to xen by U-boot, it will reserve the memory
>> in
>> the device tree.
>> In this case, when xen decides to free unused memory, dt_unreserved_regions
>> will call init_domheap_pages with the start and the end of range equals. But
>> the latter assumes that (start > end), if not Xen will hang because the
>> number of pages is equals to (unsigned)-1.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>> CC: Keir Fraser <keir@xen.org>
>> CC: Jan Beulich <jbeulich@suse.com>
>
> Ping ? Without this commit, the user is unable to pass initrd to dom0 on
> ARM.
It was fine with me.
Acked-by: Keir Fraser <keir@xen.org>
prev parent reply other threads:[~2013-11-20 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 13:37 [PATCH V3] xen: Check if the range is valid in init_domheap_pages Julien Grall
2013-11-13 14:58 ` Keir Fraser
2013-11-20 16:09 ` Julien Grall
2013-11-20 21:12 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CEB265A0.66A01%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@citrix.com \
--cc=julien.grall@linaro.org \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.