From: Keir Fraser <keir.xen@gmail.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH v2 0/2] Improvements with noreturn
Date: Mon, 25 Nov 2013 19:46:03 +0000 [thread overview]
Message-ID: <CEB9597B.405E8%keir.xen@gmail.com> (raw)
In-Reply-To: <1385388177-8866-1-git-send-email-andrew.cooper3@citrix.com>
On 25/11/2013 14:02, "Andrew Cooper" <andrew.cooper3@citrix.com> wrote:
> Make better use of noreturn. It allows optimising compilers to produce more
> efficient code.
>
> v2 comes with a reduction of the number of changes, to remove the redundant
> declaration from publically defined functions.
>
> George:
> I request that this is included for 4.4 - It is no functional change, but
> quite a nice improvement in terms of code size.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: George Dunlap <george.dunlap@eu.citrix.com>
Acked-by: Keir Fraser <keir@xen.org>
I see it did not get a release ack, and I strongly agree with that.
-- Keir
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2013-11-25 19:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 14:02 [PATCH v2 0/2] Improvements with noreturn Andrew Cooper
2013-11-25 14:02 ` [Patch v2 1/2] xen/compiler: Replace opencoded __attribute__((noreturn)) Andrew Cooper
2013-11-25 14:17 ` Jan Beulich
2013-11-25 15:29 ` Andrew Cooper
2013-11-26 12:00 ` George Dunlap
2013-11-25 14:02 ` [Patch v2 2/2] xen: Identify panic and reboot/halt functions as noreturn Andrew Cooper
2013-11-25 14:26 ` Jan Beulich
2013-11-25 15:36 ` Andrew Cooper
2013-11-25 19:46 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CEB9597B.405E8%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.