From: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
To: "Govindarajulu Varadarajan (gvaradar)" <gvaradar@cisco.com>,
Ding Tianhong <dingtianhong@huawei.com>
Cc: "Christian Benvenuti (benve)" <benve@cisco.com>,
Govindarajulu Varadarajan <govindarajulu90@gmail.com>,
"Neel Patel (neepatel)" <neepatel@cisco.com>,
Nishank Trivedi <nistrive@cisco.com>,
"David S. Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3 04/19] net: enic: slight optimization of addr compare
Date: Thu, 2 Jan 2014 04:09:34 +0000 [thread overview]
Message-ID: <CEEAE3A2.F048%ssujith@cisco.com> (raw)
In-Reply-To: <alpine.LNX.2.03.1312301341050.2286@cisco.com>
Looks good.
Acked by: Sujith Sankar <ssujith@cisco.com>
On 30/12/13 1:42 PM, "Govindarajulu Varadarajan (gvaradar)"
<gvaradar@cisco.com> wrote:
>On Mon, 30 Dec 2013, Ding Tianhong wrote:
>
>> Use possibly more efficient ether_addr_equal
>> to instead of memcmp.
>>
>> Cc: Christian Benvenuti <benve@cisco.com>
>> Cc: Sujith Sankar <ssujith@cisco.com>
>> Cc: Govindarajulu Varadarajan <govindarajulu90@gmail.com>
>> Cc: Neel Patel <neepatel@cisco.com>
>> Cc: Nishank Trivedi <nistrive@cisco.com>
>> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
>> ---
>> drivers/net/ethernet/cisco/enic/enic_pp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/cisco/enic/enic_pp.c
>>b/drivers/net/ethernet/cisco/enic/enic_pp.c
>> index 43464f0..e6a8319 100644
>> --- a/drivers/net/ethernet/cisco/enic/enic_pp.c
>> +++ b/drivers/net/ethernet/cisco/enic/enic_pp.c
>> @@ -162,7 +162,7 @@ static int enic_are_pp_different(struct
>>enic_port_profile *pp1,
>> return strcmp(pp1->name, pp2->name) | !!memcmp(pp1->instance_uuid,
>> pp2->instance_uuid, PORT_UUID_MAX) |
>> !!memcmp(pp1->host_uuid, pp2->host_uuid, PORT_UUID_MAX) |
>> - !!memcmp(pp1->mac_addr, pp2->mac_addr, ETH_ALEN);
>> + !ether_addr_equal(pp1->mac_addr, pp2->mac_addr);
>> }
>>
>> static int enic_pp_preassociate(struct enic *enic, int vf,
>> --
>> 1.8.0
>>
>
>looks good for me
>
>Acked-by: Govindarajulu Varadarajan <govindarajulu90@gmail.com>
prev parent reply other threads:[~2014-01-02 4:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 7:40 [PATCH net-next v3 04/19] net: enic: slight optimization of addr compare Ding Tianhong
2013-12-30 8:12 ` Govindarajulu Varadarajan
2014-01-02 4:09 ` Sujith Sankar (ssujith) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CEEAE3A2.F048%ssujith@cisco.com \
--to=ssujith@cisco.com \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=govindarajulu90@gmail.com \
--cc=gvaradar@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neepatel@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=nistrive@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.